TrinityCore / TrinityCore/TrinityCore
[3.3.5a] Instance bind incorrect check
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.8k
- Forks
- 6.4k
- Avg merge
- 3d 16m
- Merged PRs (30d)
- 6
Description
Hello,
I was inspecting some code for SPELL_EFFECT_SUMMON_PLAYER for inspiration when I stumbled upon the following weird logic:
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Spell.cpp#L5495
On this line we check for IsRaid for an instance bind. As a matter of fact not only raids have instance binds but also Heroic instances do as well (for 24h). Is this logic missing on purpose from this piece of code? If yes please disregard my note and close this issue.
TC hash/commit:
607034064f04b33f5de6e166a87c8e1c8a2fe953
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/server/game/Spells/Spell.cpp around line 5495, using the referenced 3.3.5 commit as context. Trace the instance-bind check and verify how heroic instances are represented compared with raids. Done means determining whether the check is intentional and, if not, updating it so the relevant instance types are handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100