Java required when making multiple targets

Open
#907 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java, javascript, python
Domain
compilers

Research direction

Start in transcrypt/modules/org/transcrypt/compiler.py around lines 233-241 and reproduce making multiple targets without --build when the target does not yet exist. Trace why existing target code invokes the Closure Compiler jar, then verify that the same case no longer requires Java while existing-target processing still works.

Written by the indexing model from the issue text.

Description

When just making (no --build option) for multiple targets, the compiler tries to load existing target code and ends up running the closure compiler (for minification) jar which requires Java to be installed.

https://github.com/TranscryptOrg/Transcrypt/blob/32b216bcd3cb08c81645528c1a108a78be0b2325/transcrypt/modules/org/transcrypt/compiler.py#L233-L241

There should be a way to avoid having Java installed when the target does not actually exist yet.

Dominant language
Python
Stars
2.9k
Forks
218
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TranscryptOrg/Transcrypt

All issues in TranscryptOrg/Transcrypt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.