float() does not behave the same as CPython
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- javascript, python
- Domain
- compilers
Research direction
Start at transcrypt/modules/org/transcrypt/builtin.js#L263, where the transcrypted float() implementation is identified, and compare its behavior with CPython for strings containing trailing non-numeric text and invalid values. Done means float() raises the expected ValueError instead of partially parsing input or returning NaN.
Written by the indexing model from the issue text.
Description
Right now the transcrypted float() uses JS parseFloat, but parseFoat allows for non-numeric values in the string it is partsing. It jsut stops parsing when it hits a non-numeric value instead of throwing NaN. CPython will instead raise a ValueError.
parseFloat("123.pdf")
123
float("123.pdf")
Traceback (most recent call last):
File "/opt/pycharm/plugins/python-ce/helpers/pydev/pydevconsole.py", line 364, in runcode
coro = func()
File "<input>", line 1, in <module>
ValueError: could not convert string to float: '123.pdf'
Maybe use Number instead of parseFloat?
Update: float() is also returning NaN in some cases without throwing an error.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 218
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TranscryptOrg/Transcrypt
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
TranscryptOrg/Transcrypt#913 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
TranscryptOrg/Transcrypt#911 · 2 comments ·
-
SUB: documentation
Difficulty 1/5 Under an hour Newbie friendliness 62/100
TranscryptOrg/Transcrypt#656 · 7 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
TranscryptOrg/Transcrypt#914 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
TranscryptOrg/Transcrypt#910 ·
All issues in TranscryptOrg/Transcrypt
Similar issues
-
area/auth bug comp/agent P3 platform/discord type/security
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NousResearch/hermes-agent#117848 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100