context.__exit__ is not called if with block returns

Open
#799 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, python
Domain
compilers

Research direction

Start by reproducing the provided Python context-manager example and tracing the compiler path that generates the shown JavaScript for the with block. The fix is done when exit is called before a return leaves the block, while exception handling still behaves as shown.

Written by the indexing model from the issue text.

Description

Please transcrypt the following code:

class Context:
    def __enter__(self):
        print("enter")

    def __exit__(self, exc_type, exc_val, exc_tb):
        print("exit")
        return False


def main():
    with Context():
        print("exit is not called")
        return


document.addEventListener('DOMContentLoaded', main)

The main function ist transcripted to

export var main = function () {
	var __withid0__ = Context ();
	try {
		__withid0__.__enter__ ();
		print ('exit is not called');
		return ;
		__withid0__.__exit__ ();
	}
	catch (__except0__) {
		if (! (__withid0__.__exit__ (__except0__.name, __except0__, __except0__.stack))) {
			throw __except0__;
		}
	}
};

As you can see the return statement is generated before calling exit.

Dominant language
Python
Stars
2.9k
Forks
218
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TranscryptOrg/Transcrypt

All issues in TranscryptOrg/Transcrypt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.