Dictionary equality comparison differs from CPython

Open
#757 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, python
Domain
compilers

Research direction

Start with the issue's Python and transpiled JavaScript examples, then locate how Transcrypt represents dictionaries and emits or evaluates equality comparisons. Compare the generated behavior with CPython for dictionaries whose insertion order differs. Done means equivalent dictionaries compare equal in the generated JavaScript, including the reported example.

Written by the indexing model from the issue text.

Description

IS: duplicate

I'm not sure if this a known difference with CPython, but when comparing dictionaries for equality, the transpiled JS always returns false. I assume this has to do with how JavaScript compares objects in general. For example:

Python Code:

def dict_test():
    x = {'a': 12, 'c': 99, 'b': 54}
    y = {'a': 12, 'b': 54, 'c': 99}
    print(x == y)

# returns True

Transcrypted Code:

export var dict_test = function () {
    var x = dict({"a": 12, "c": 99, "b": 54});
    var y = dict({"a": 12, "c": 99, "b": 54});
    print(x == y)
};

// returns false

I'm assuming the only solution would be to do a recursive comparison of values, or use a 3rd party library like Lodash's _.isEqual() function.

Dominant language
Python
Stars
2.9k
Forks
218
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TranscryptOrg/Transcrypt

All issues in TranscryptOrg/Transcrypt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.