Literal bytes >=128: b"\x80"

Open
#706 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, python
Domain
compilers

Research direction

Start by reproducing the examples in x.py with python -m transcrypt -b -m x.py, comparing byte literals at and above 128 with the working cases. Then inspect the compiler and minifier entry points reached by that command, using the generated x.js and reported parse error as the failure signal. Done means the affected examples compile successfully without the shown errors.

Written by the indexing model from the issue text.

Description

IS: enhancement STATE: postponed

This is broken:

x = b"\x80"
$ python -m transcrypt -b -m  x.py
Error while compiling (offending file last):
        File 'x', line 1, namely:
        
        Error while compiling (offending file last):
        File 'x', line 1, namely:
        

Aborted

b"\x81" is also broken, while b"\x7F" works fine.

This workaround compiles with the -n flag, but breaks when minified:

x = (0x80).to_bytes(1, "big")
$ python -m transcrypt -b -m  x.py
Saving minified target code in: /Users/crusaderky/PycharmProjects/10char/__target__/x.js
x.pretty.js:4: ERROR - Parse error. Semi-colon expected
export var x = 128.to_bytes (1, 'big');
                   ^

This compiles (but I didn't test yet if it actually runs):

x = 0x80
y = x.to_bytes(1, "big")

This also compiles:

x = chr(0x80)
Dominant language
Python
Stars
2.9k
Forks
218
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TranscryptOrg/Transcrypt

All issues in TranscryptOrg/Transcrypt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.