Context managers don't `__enter__` or `__exit__`

Open
#532 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, python
Domain
compilers

Research direction

Start by reading the compiler handling for the with statement and the existing expectation that invoked objects provide close(). Compare that behavior with Python’s __enter__ and __exit__ context-manager idiom. Done should include a clearly established compatibility behavior that preserves any existing close() use.

Written by the indexing model from the issue text.

Description

IS: exploratory

I noticed that Transcrypt doesn't support the standard python context manager class idiom, even though it does support the with statement.

Looking at the compiler, I notice that it expects a close() method for objects being invoked by with(). Is that intended for things like websockets? Before considering adding the usual python behavior I'd like to know what is currently expected so I can preserve it.

Dominant language
Python
Stars
2.9k
Forks
218
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TranscryptOrg/Transcrypt

All issues in TranscryptOrg/Transcrypt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.