String.join causes maximum recursion depth to be reached on FF and Chrome

Open
#380 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, python
Domain
compilers

Research direction

Start by reproducing the reported 'foo'.join('bar') case in a browser console, then locate the Transcrypt compiler output that generates the shown String.prototype.join block. Done means the generated JavaScript no longer recurses in Firefox or Chrome and the reproduction succeeds.

Written by the indexing model from the issue text.

Description

STATE: under construction

Awesome job! This is a great project and I've really enjoyed working with it so far.

I did come across one minor issue. I apologize in advance if it's already been addressed or if it's an error on my part.

I noticed that my transpiled code contains the following block

String.prototype.join = function (strings) {
return strings.join (this);
};

This causes FireFox and Chrome to recurse infinitely.

Steps to reproduce:

  1. open the dev console of any page which includes transpiled javascript created with Transcrypt
  2. enter: 'foo'.join('bar')
  3. Maximum recursion depth reached
Dominant language
Python
Stars
2.9k
Forks
218
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TranscryptOrg/Transcrypt

All issues in TranscryptOrg/Transcrypt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.