v4.0.15: waveform for video with multiple audio tracks is regenerated every time

Open
#10,872 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
csharp

Research direction

Trace the waveform generation and cache lookup used after selecting an audio track, starting with the code path for opening the video and choosing track #3. Reproduce the scenario with two subtitle files and the same video, then verify that the existing waveform is loaded rather than regenerated for the selected track.

Written by the indexing model from the issue text.

Description

Prerequisites:

  • I have an active subtitle file open that I am working with.
  • I have a video file with 3 audio tracks. When opening the video, SubtitleEdit asks me to select one of the tracks. I select track #3.
  • I click onto the waveform, and SubtitleEdit starts generating the waveform for track #3.

Test Scenario:

  • I open a new/different subtitle file.
  • I open the same video as before. When opening the video, SubtitleEdit asks me to select one of the tracks. I select track #3.
  • I click onto the waveform.

Expected behavior:

  • SubtitleEdit recognizes that it already has the waveform for audio track #3 of this video file and loads it.

Actual behavior:

  • SubtitleEdit starts generating the waveform all over again.
Dominant language
C#
Stars
14.3k
Forks
1.3k
Avg merge
1h 19m
Merged PRs (30d)
782

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.