ASSA advanced effects observations

Open
#10,318 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
csharp
Domain
desktop

Research direction

No files or tests are named. Start by locating the ASSA subtitle-effect implementation and the code that applies effects to a line or selection; done means effects preserve the style-defined position and can target selected words without affecting the rest of the line.

Written by the indexing model from the issue text.

Description

Couple observations:

  1. When you add some effect to subtitle line, it completely disregards the position of the text, and puts it where it wants. It would be more useful, if the position of the text would stay where it was, but the effect would add onto it's position (so if you add wave, the wave effect would happen relatively to the position that the subtitle line style defined.
  2. It would be nice to be able to apply the effect to selected words, not whole line.
Dominant language
C#
Stars
14.3k
Forks
1.3k
Avg merge
1h 19m
Merged PRs (30d)
782

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.