JSS function names are confusing
Open
@megoth is already working on this.
Since Feb 24, 2020.
- Dominant language
- TypeScript
- Stars
- 153
- Forks
- 46
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Description
In https://github.com/solid/solid-ui/blob/master/src/jss/index.ts
getClasses returns a StyleSheet object.
getStyleSheet returns a Jss object.
Wouldn't it be better to rename getClasses to getStyleSheet, and getStyleSheet to getJssObject?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.