SolidOS / SolidOS/solid-ui

Find out intended behaviour to shortNameForFolder

Open
#196 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
153
Forks
46
Avg merge
1d 8h
Merged PRs (30d)
7

Description

shortNameForFolder returns 'example.com' for 'https://example.com/' and '/' for 'https://'.
I'm not certain this is actually by design, it might be that the intended behaviour was that the domain root would already get labeled '/'. That would make more sense to me for a filebrowser.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating shortNameForFolder and reproduce its results for https://example.com/ and https://. Determine the intended label for a domain root with the maintainers, then document the decision and add coverage for the agreed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.