PTDF matrix does not use lookup dictionary when retrieving a row of the matrix

Open
#79 3 comments 0 reactions 1 assignee View on GitHub

@jd-lara is already working on this.

Since Sep 21, 2024.

Assessment

This issue has not been assessed yet.

Description

documentation

I found that the PTDF matrix does not recognize the lookup dictionary when trying to access the vector of line data corresponding to a given bus. For example, in the code below, I get an error on the last line because the number for the bus "Cobb" (321) is greater than that dimension of the matrix (73). This is using Julia 1.9 with PSY v3.3.0, PNM v0.10.0, and PSCB v1.2.5.


using PowerNetworkMatrices, PowerSystems, PowerSystemCaseBuilder
rts_sys = build_system(PSITestSystems, "test_RTS_GMLC_sys")

ptdf = PTDF(rts_sys)
bus = get_component(Bus, rts_sys, "Cobb")

vector = ptdf[:, get_number(bus)]

This error came up because I was using the code from PowerSimulations.jl here to compute the LMPs of a Sienna simulation. This was fairly easy to work around (just mapping the values in ptdf.axes[1] to the order they appear) but wasn't sure if this was expected behavior. Wondering if it would make sense to have ptdf.axes[1] be the bus names instead of the bus numbers to avoid this issue. For example, if I instead call ptdf["A1", :], I do get the expected behavior where it gives me the column corresponding to Line "A1".

Also, as a related note, it was a little confusing to me that the PTDF matrix expects the indexes to be passed as column then row, rather than row then column (e.g., ptdf["A1", 101] rather than ptdf[101, "A1"]) since the dimensions in ptdf.axes are listed with the bus number as dimension 1 and line names as dimension 2. Just an observation as a first time user. Overall though, thank you for making and supporting the Sienna suite. It has been very helpful.

Dominant language
Julia
Stars
31
Forks
22
Avg merge
1d 11h
Merged PRs (30d)
18

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Sienna-Platform/PowerNetworkMatrices.jl

All issues in Sienna-Platform/PowerNetworkMatrices.jl

Similar issues

More Julia issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.