Sienna-Platform / Sienna-Platform/PowerNetworkMatrices.jl

`_partition_members_by_impedance_angle` is order-dependent

Open
#342 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

invalid
Dominant language
Julia
Stars
31
Forks
22
Avg merge
1d 11h
Merged PRs (30d)
18

Description

I think _partition_members_by_impedance_angle depends on the order you read branches. E.g., with tolerance 0.1:

  • Angles [0.5, 0.4, 0.3] = 2 bins
  • Angles [0.4, 0.5, 0.3] = 1 bin

I'm not sure if this is actually a problem, just something I noticed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate _partition_members_by_impedance_angle and reproduce the two angle-order examples with tolerance 0.1. Determine whether the differing bin counts are expected; done means documenting the intended behavior and, if order independence is required, adding coverage for both orderings and correcting the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.