SAP-samples / SAP-samples/codejam-code-based-agents

JavaScript track: exercises 06 and 07 appear to be in the wrong order

未关闭 适合新手
#35 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Python
星标
54
派生
36
PR 合并指标
30 天内没有已合并 PR

描述

Summary

06-discover-connected-crimes.md references code that's only introduced in 07-solve-the-crime.md:

  • Around line 238, it calls this.orchestrationClient.chatCompletion(...), but orchestrationClient as a class field is only declared and constructed in exercise 07's Step 1 (07-solve-the-crime.md, "Add orchestrationClient as a class field and initialize it in the constructor").
  • Around line 213, it instructs learners to add the new node "before leadDetectiveNode" — but leadDetectiveNode is also only created in exercise 07.

Effect

Following the exercises in their numbered order (06 then 07), a learner's investigationWorkflow.ts wouldn't type-check at exercise 06's step — this.orchestrationClient doesn't exist as a class member yet, and leadDetectiveNode doesn't exist to insert before.

Suggested fix

Either:

  1. Swap the exercise order (make current 07's class-field/constructor setup + Lead Detective node come before current 06's Intelligence Researcher node), or
  2. Move the orchestrationClient class-field/constructor setup into exercise 06 itself, and have exercise 07 only add leadDetectiveNode.

Either way, the sequencing needs to match what the code in each step actually depends on.

Environment

Reproduced on a personal SAP AI Core tenant, JavaScript/TypeScript track, exercises 01–07 followed in numbered order.

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 06-discover-connected-crimes.md 和 07-solve-the-crime.md 开始,对照其中引用的 investigationWorkflow.ts 步骤及其编号顺序。检查 orchestrationClient 和 leadDetectiveNode 是否在 exercise 06 使用它们之前引入,然后依次查看 exercise 01–07,确认 JavaScript/TypeScript 工作流在每一步都能通过类型检查。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, typescript
领域
documentation
Issue 类型
文档
难度
2/5
预计耗时
1-3 小时
活跃度
活跃
描述清晰度
描述清楚
新手友好度
78/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。