RustPython / RustPython/Parser
Consolidate parsing of `Expr::Name` in `TypeAliasName`, `MatchName`, and `Atom<Goal>`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 117
- Forks
- 38
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 1
Description
We have three parser descriptions for in the LALRPOP grammar for generating Expr::Name from an Identifier.
TypeAliasNameMatchNameAtom<Goal>
These could be consolidated into a single reused identifier for simplicity and clarity.
Originally posted by @MichaReiser in https://github.com/RustPython/Parser/pull/97#discussion_r1263930630
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the LALRPOP grammar definitions for TypeAliasName, MatchName, and Atom, then compare how each converts an Identifier into Expr::Name. Consolidate those descriptions into one reusable identifier and verify that the existing parsing behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100