ci: Typos check does not understand `concat!("hex-string")`

Open
#563 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
ci-cd, tooling

Research direction

Reproduce the typos check from the commit linked in the issue, focusing on the string at src/pkcs1v15/encrypting_key.rs:54 and the change disabled in #562. Determine how the check handles concat!("hex-string") and verify that the check no longer reports the hexadecimal text as a typo.

Written by the indexing model from the issue text.

Description

typos-check here: https://github.com/RustCrypto/RSA/commit/1e21564801803af8f8944f1e40a89178bb08a4fc

Warning: "ba" should be "by" or "be".

error: ba should be by, be
--> ./src/pkcs1v15/encrypting_key.rs:54:20

|

54 | "92ba5fe2430203010001",

I've had to disable it in #562 as it doesn't seem to understand macros.

Dominant language
Rust
Stars
673
Forks
190
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RustCrypto/RSA

All issues in RustCrypto/RSA

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.