numtraits libm feature and num-bigint-dig directly depends on C library libm

Open
#686 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
c, rust
Domain
build-system, cryptography

Research direction

Start with the dependency and feature declarations for numtraits, libm, and num-bigint-dig, then check the README's claim that the crate is pure Rust. Verify whether the reported configuration links to libm; done means either removing that C dependency or clearly documenting it if removal is not feasible.

Written by the indexing model from the issue text.

Description

Hello there,
you are including the numtraits crate with the libm feature enabled.
This causes linking with libm.

I am trying to use this crate in a scenario where linking to libm (or other C code) is not possible (Complex cross compilation).
I assumed since you mention that this is pure rust that it does not rely on C code.

If its possible could you perhaps evaluate removing this dependency on C code and if it seems feasible remove it?

If its not possible or would require too much effort then feel free to close this issue,
but perhaps a small clarification in the readme that this crate does
link libm would have saved me some time.

Dominant language
Rust
Stars
673
Forks
190
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RustCrypto/RSA

All issues in RustCrypto/RSA

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.