https://docs.rs/rsa/latest/rsa/struct.RsaPrivateKey.html#method.precompute is public

Open
#338 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
cryptography

Research direction

Start at the RsaPrivateKey::precompute entry point linked in the issue and review the referenced discussion in RustCrypto/RSA#23. Trace how construction currently invokes precomputation, then verify that the method is no longer publicly exposed while construction behavior remains unchanged.

Written by the indexing model from the issue text.

Description

While looking at perf, I noticed this precompute method: https://docs.rs/rsa/latest/rsa/struct.RsaPrivateKey.html#method.precompute

In https://github.com/RustCrypto/RSA/issues/23#issuecomment-525251114 it mentions that this should be private and that it is implicitly called during construction.

That issue was closed, but it seems like this still needs to be resolved

Dominant language
Rust
Stars
673
Forks
190
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RustCrypto/RSA

All issues in RustCrypto/RSA

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.