Redundant removeAllTags call

Open Beginner friendly
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Domain
frontend

Research direction

Start at modules/react-roblox/src/client/roblox/RobloxComponentProps.lua around line 365 and inspect the surrounding cleanup loop. Verify which element has already been cleared and confirm the remaining tag-removal call targets the intended element. Done means the redundant target is corrected and the relevant existing tests pass.

Written by the indexing model from the issue text.

Description

https://github.com/Roblox/react-luau/blob/9351444c2db37caa08b38ad5de90f438db9221ea/modules/react-roblox/src/client/roblox/RobloxComponentProps.lua#L365

This almost certainly is supposed to be removeAllTags(descElement) as domElement was already cleared before the loop.

Dominant language
Luau
Stars
568
Forks
49
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Roblox/react-luau

All issues in Roblox/react-luau

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.