CMake files do not automatically download the libraries when ran

Open

#16 opened on Nov 25, 2019 26 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: cmake, cpp
Domain: build-system

Research direction

Start by reading FindSol.cmake and FindRaylib.cmake, then reproduce the dependency lookup on OS X 10.15.1 with the existing find_package and FetchContent flow. Check whether the sol2 and raylib libraries are detected or downloaded as intended, and confirm that the project completes its build without requiring the invalid VERBOSE flag.

Written by the indexing model from the issue text.

Description

Hi,

The files FindSol.cmake and FindRaylib.cmake do not automatically download the libraries on OS X 10.15.1.

If you change the flag QUIET to VERBOSE it fails but then carries on to download and building steps:


find_package(sol 3.0 VERBOSE)
if (NOT sol_FOUND)
  include(FetchContent)
  FetchContent_Declare(
    sol
    GIT_REPOSITORY https://github.com/ThePhD/sol2.git
    GIT_TAG 6d4a5d3ef66d605c54093edb673c14e373969a08
  )
  FetchContent_GetProperties(sol)
  if (NOT sol_POPULATED) # Have we downloaded sol2 yet?
    set(FETCHCONTENT_QUIET NO)
    FetchContent_Populate(sol)
    add_subdirectory(${sol_SOURCE_DIR} ${sol_BINARY_DIR})
    set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake" "${sol_SOURCE_DIR}/cmake" "${sol_SOURCE_DIR}/cmake/Modules")
  endif()
endif()

The verbose flag is not valid so it carries on, i installed raylib view brew but it didn't find the libraries in the first place.

Dominant language: C++
Stars: 120
Forks: 22
Avg merge: 50m
Merged PRs (30d): 1

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.