Feature Request: Add unfold construct to Flowable/Observable
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Java
- Sterne
- 48.2k
- Forks
- 7.6k
- Ø Merge
- 39 Min.
- Gemergte PRs (30 T.)
- 11
Beschreibung
Version 3.1.4
Scala as of 2.13 and Akka (another reactive framework) have added various unfold patterns, and I'm finding a need for this currently. Here's the use case - pagination of responses to a "cursor"-like REST api.
Essentially, I'd like to make a Flowable that makes requests to get another page - where it starts without a "continuation" parameter, and keeps making requests (honoring backpressure) until the response comes without a "continuation".
Flowable.create doesn't seem to deal with the backpressure well, and Flowable.generate is blocking, which seems disappointing as Flowable.fromFuture is great at dealing with async http clients.
This unfold pattern seems to offer what would be very helpful to the cause - where a new request isn't made until the subscriber asks for more, and the termination state is known from some inspection of the previous element in the feed (the http response, or the json parsing of it).
Here's a stab of making these using RxJava constructs; it would be nice if Flowable.unfold and Flowable.unfoldMaybe (and Observable too) could be added to RxJava itself.
import java.util.Optional;
import java.util.function.Function;
import io.reactivex.rxjava3.core.Flowable;
import io.reactivex.rxjava3.core.Maybe;
import io.reactivex.rxjava3.core.MaybeSource;
public class Unfold {
public static class Pair<L, R> {
private final L left;
private final R right;
public Pair(L left, R right) {
this.left = left;
this.right = right;
}
public L getLeft() {
return left;
}
public R getRight() {
return right;
}
}
public static <S, E> Flowable<E> flowableUnfold(S state, Function<S, Optional<Pair<S, E>>> generator) {
return Flowable.defer(() -> Flowable.fromOptional(generator.apply(state)))
.flatMap(pair -> Flowable.just(pair.getRight())
.concatWith(flowableUnfold(pair.getLeft(), generator)));
}
public static <S, E> Flowable<E> flowableUnfoldMaybe(S state, Function<S, ? extends MaybeSource<Pair<S, E>>> generator) {
return Flowable.defer(() -> Flowable.fromMaybe(generator.apply(state)))
.flatMap(pair -> Flowable.just(pair.getRight())
.concatWith(flowableUnfoldMaybe(pair.getLeft(), generator)));
}
}
And some scala to test it
@RunWith(classOf[JUnitRunner])
class UnfoldTest extends AnyFlatSpec with Matchers {
"flowableUnfold" should "work with range of 0 to 10" in {
val flowable = Unfold.flowableUnfold[(Int, Int), Int]((0, 10), {
case (start: Int, end: Int) if start < end =>
Option(new Pair(start + 1 -> end, start)).asJava
case _ => None.asJava
})
flowable.toList.blockingGet().asScala shouldBe (0 until 10)
}
"flowableUnfoldMaybe" should "work with range of 0 to 10" in {
val flowable = Unfold.flowableUnfoldMaybe[(Int, Int), Int]((0, 10), {
case (start: Int, end: Int) if start < end =>
Maybe.fromCallable(() => new Pair(start + 1 -> end, start))
case _ => Maybe.empty()
})
flowable.toList.blockingGet().asScala shouldBe (0 until 10)
}
}
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, die vorhandenen Flowable.create-, Flowable.generate- und Flowable.fromFuture-Einstiegspunkte zu lesen und ihr Backpressure- sowie asynchrones Verhalten zu vergleichen. Prüfe die vorgeschlagenen Flowable.unfold-, Flowable.unfoldMaybe- und Observable-Gegenstücke und verwende anschließend die bereitgestellten Range-Beispiele, um Abschluss, Nachfrage und asynchrones Verhalten zu definieren, bevor du die Implementierung und Tests in Betracht ziehst.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- java
- Bereich
- backend-api-design
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100