non-integer value support for minoverlap argument of foverlaps function

Open
#979 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start at the foverlaps function and inspect how minoverlap is validated and used for POSIXct-derived numeric timeseries data. Compare the current behavior with existing foverlaps tests, then add coverage showing that an appropriate non-integer minoverlap is accepted and produces the expected overlaps.

Written by the indexing model from the issue text.

Description

feature request non-equi joins

I frequently need to find the overlaps in timeseries data. These can be of the order of milliseconds sometimes. Minoverlap argument needs to have a value of greater than 1 and it should be integer. I currently find overlaps over millisecond data instead of seconds data as a workaround. But float value support for minoverlap will be helpful for analysing POSIXct (converted into numeric) data direclty without for a need to do any furthur processing.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.