print.trunc.cols off by one?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
Research direction
Reproduce the examples using print.data.table, options(width=10), and datatable.print.trunc.cols=TRUE. Inspect how print.data.table accounts for available width and trailing characters; done when dt7 prints at width=10 without wrapping and the boundary behavior is covered by a regression test.
Written by the indexing model from the issue text.
Description
Is this an off by one bug?
> options(datatable.print.trunc.cols=TRUE)
> options(width=10)
> (dt7=data.table(x="1234567"))
1 variable not shown: [x]
> (dt6=data.table(x="123456"))
x
1: 123456
Above we see dt6 is 9 characters wide (6 characters of data and 3 of row number, colon, space), and dt7 gets truncated, even though I expected that it should print (we have enough space for it with width=10).
Below we see that dt7 prints if we set width=11, which enables printing of this 10 character wide table.
> options(width=11)
> dt7
x
1: 1234567
Does the current code count the trailing newline as one of the characters toward the width limit? (I expect it should not)
For reference, ?print.data.table says
trunc.cols: If ‘TRUE’, only the columns that can be printed in the
console without wrapping the columns to new lines will be
printed (similar to ‘tibbles’).
?options says
‘width’:
controls the maximum number of columns on a line used in
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·