`round.ITime` fails when given numeric `digits` by `xfun::md_table`

Open
#7,638 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Reproduce the failure with data.table::as.ITime('23:58:00') |> data.frame(x=_) |> xfun::md_table(), then inspect the round.ITime and as.numeric.ITime entry points shown in the report. Compare the numeric-digits path with the behavior expected by xfun::md_table and add regression coverage; done means the example no longer errors while preserving existing ITime behavior.

Written by the indexing model from the issue text.

Description

Found while pre-rendering examples for the website:

data.table::as.ITime('23:58:00') |> data.frame(x=_) |> xfun::md_table()

Error in match.arg(digits) : 'arg' must be NULL or a character vector

5: stop("'arg' must be NULL or a character vector")
4: match.arg(digits)
3: setattr(switch(match.arg(digits), hours = as.integer(round(unclass(x)/3600) * 
       3600), minutes = as.integer(round(unclass(x)/60) * 60)), 
       "class", "ITime")
2: round.ITime(structure(86280L, class = "ITime"), 3)
1: xfun::md_table(data.frame(x = data.table::as.ITime("23:58:00")))

This happens when md_table gives 3 as the default argument to round(column): https://github.com/yihui/xfun/blob/046d83997ccd44634210d8af227019111e780b49/R/markdown.R#L293-L299

round(Sys.time(), 3) would also fail, but md_table skips columns that aren't is.numeric(). Should as.numeric.ITime return FALSE as well?

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.