Deprecate %notin%
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reading the linked R base match.R change and the discussion in #7446, then review how data.table currently defines and exports %notin%. Check the stated CRAN dependents and determine what a deprecation plan should look like once R includes the operator in a release; the issue does not yet define a concrete implementation or completion test.
Written by the indexing model from the issue text.
Description
R itself recently started exporting a %notin% operator:
That collides with our own %notin%:
@aitap in #7446 mentioned some ideas for this deprecation process, which will be new to us:
Three CRAN packages import
%notin%:bruceR,tidyfst, andweatherOz; the first two for re-exporting. Any clever tricks (à lacedta?) we might use so that interactive users who would getbase::`%notin%`anyway will not get penalised? I see that some packages (e.g.backports) export objects conditionally on R version. Should we try to eventually useif (getRversion() < "4.6.0")) export("%notin%")and similarly emit deprecation warnings only on R ≥ 4.6.0?
I would like to see R commit to including it in a release before we do anything too drastic.
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·