froll.Rraw could use test()'s options verbose

Open
#7,013 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
testing

Research direction

Start in froll.Rraw and inspect how test(...) currently wraps options(datatable.verbose=TRUE) and restores them afterward. Compare the existing rolling-function tests with the proposed test(..., options(datatable.verbose=TRUE)) form; done means the verbose option is passed through the test call without the surrounding global option changes.

Written by the indexing model from the issue text.

Description

froll tests

instead of using

options(datatable.verbose=TRUE)
test(...)
options(datatable.verbose=FALSE)

we could use

test(..., options(datatable.verbose=TRUE))

Filling out this issue to not forget.
As this is not a high priority, it is postponed till rolling functions related PRs are merged, to reduce work needed to resolve merge conflicts.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.