Implement arguments `optional` and `nm` in `as.data.frame.ITime`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 44/100
Research direction
Start with the as.data.frame.ITime method and compare its arguments and behavior with help(as.data.frame) and as.data.frame.vector. Check how the method produces the V1 column in the supplied data.frame example, then verify that optional and nm are handled consistently with the base implementation.
Written by the indexing model from the issue text.
Description
This came up on Stack Overflow.
library(data.table)
DateTime <- as.POSIXct(c("2025-05-16 00:00:02 CDT", "2025-05-16 00:00:03 CDT", "2025-05-16 00:00:06 CDT", "2025-05-16 00:00:07 CDT"))
TimeOfDay <- as.ITime(DateTime)
data.frame(DateTime, TimeOfDay)
# DateTime V1
#1 2025-05-16 00:00:02 00:00:02
#2 2025-05-16 00:00:03 00:00:03
#3 2025-05-16 00:00:06 00:00:06
#4 2025-05-16 00:00:07 00:00:07
The user was wondering about the column name "V1", which is hard-coded in as.data.frame.ITime. See help(as.data.frame) and the code of as.data.frame.vector regarding the needed arguments and their implementation. This should be straight-forward unless it trips something up elsewhere.
I'm pretty sure you could just do this:
as.data.frame.ITime <- function(...) NextMethod()
But I haven't looked at the original ggplot2 issue.
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·