awful one liners don't improve readability or performance
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- c
- Domain
- developer-experience
Research direction
Start with the three referenced locations in src/fread.c at lines 1259, 1811, and 2512, then search nearby code for similar one-line control-flow statements. Separate increment operations from control flow where applicable, preserve behavior, and run the project's relevant tests to confirm the parser still works.
Written by the indexing model from the issue text.
Description
This is a pattern I've seen in various places in the code. Collapsing everything into one line doesn't make the code run faster, the compiler is smart enough to sort it out.
examples:
https://github.com/Rdatatable/data.table/blob/f032d6682b87c97e24acbb3b7e40a96626b46c67/src/fread.c#L1259
https://github.com/Rdatatable/data.table/blob/f032d6682b87c97e24acbb3b7e40a96626b46c67/src/fread.c#L1811
https://github.com/Rdatatable/data.table/blob/f032d6682b87c97e24acbb3b7e40a96626b46c67/src/fread.c#L2512
I think it's especially important to separate operations like the increment (++) operator away from control flow statements. Again, this doesn't cost any performance.
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·