Seal of Approval should also check against devel DT

Open
#6,927 23 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
r
Domain
ci-cd, testing

Research direction

Start with Seal_of_Approval.md and review the issue discussion about testing approved packages against a published development version of data.table. Identify the required checks and how the repository and GitHub/GitLab CI templates should obtain that version without install_github. Done means the approach and template support reliable compatibility testing for approved packages.

Written by the indexing model from the issue text.

Description

governance

As per our internal discussion, we would like that packages which received "Seal of Approval", to be tested in their own CI against development version of data.table (aside from stable CRAN version).

By development version of data.table I mean not the head of master branch (so do not use install_github), but the most recent master branch that passed some/basic/all (to be decided) checks.

Rather than install_github or similar, we will simply use options(repos = ...) to point to our R package repository where devel version of DT can be obtained automatically, and data.table published under this repo will be already tested.

That will enable us, developers of data.table, to provide more reliable experience for users of those "approved" packages, as any breaking changes (or incompatibility between devel approved and devel data.table) will be detected as soon as possible.

More about seal of approval in: https://github.com/Rdatatable/data.table/blob/master/Seal_of_Approval.md

We are going to provide a template CI yaml file (github/gitlab), which likely won't need any/much changes. Possibly submitting PRs to approved packages.

@Rdatatable/seal-of-approval are welcome to provide their feedback/comments on this idea.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.