Test C locale breaks test suite

Open
#6,564 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
macos, r
Domain
internationalization, testing-qa

Research direction

Start by reproducing the issue with LC_ALL=C and the ~/.Renviron setup, then run R CMD check on data.table_1.16.2.tar.gz. Inspect test.data.table() around test 2194.7 and compare the expected internal-error result on MacOS Apple Silicon. Done means the C-locale test suite produces the expected result without breaking the release check.

Written by the indexing model from the issue text.

Description

tests

Something for after the patch release found in the release process (but don't believe it should stop the current patch release):

# Test C locale doesn't break test suite (#2771)
echo LC_ALL=C > ~/.Renviron
R
Sys.getlocale()=="C"
q("no")
R CMD check data.table_1.16.2.tar.gz
rm ~/.Renviron

This makes test.data.table() fail on MacOS Apple Silicon on test 2194.7

**** Full long double accuracy is not available. Tests using this will be skipped.

Running test id 2194.7          Test 2194.7 produced 0 errors but expected 1
Expected: Internal error.*types or lengths incorrect
Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.