colnamesInt() has unfriendly behavior w.r.t. missing (NA) columns
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start at the private colnamesInt() entry point and inspect its call sites and existing tests to determine whether missing inputs can reach it. If NA is possible, define and test friendlier behavior; otherwise remove tests covering impossible missing inputs. Verify the relevant data.table tests after making the chosen change.
Written by the indexing model from the issue text.
Description
It's a bit strange that `NA` returns `0L` for character input, but `NA_integer_` for numeric input.
In fact I find the current behavior odd as well:
data.table:::colnamesInt(iris, NA_integer_)
# Error in data.table:::colnamesInt(iris, NA_integer_) :
# argument specifying columns received non-existing column(s): cols[1]=-2147483648
I think it's outside the scope of this PR though, I'll file a follow-up issue.
Originally posted by @MichaelChirico in https://github.com/Rdatatable/data.table/pull/6068#discussion_r1560148562
First, we should check that it's actually possible to provide NA to this column since it's a private function (maybe we fully control all inputs & know for sure it can't receive missing inputs).
If user might provide NA, we should handle this better.
If NA input is impossible, we should drop tests with missing input.
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·