Ensure proper handling of "partially missing" complex inputs where appropriate
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
Research direction
Start with coalesce(), especially fcoalesce(), and compare its handling of fully and partially missing complex values with the examples in this issue. Check whether related complex-value handling elsewhere in the codebase has the same behavior. Done means the expected missingness behavior is established and the relevant tests are green.
Written by the indexing model from the issue text.
Description
Follow-up to #5748.
We need to ensure our complex handling behaves "as expected" in the improved world of missingness for complex values in R.
coalesce() in particular seems worthy of further scrutiny (skipped for now in the interest of just getting tests green as quickly as possible):
showz = \(z) cbind(Re = Re(z), Im = Im(z))
showz(fcoalesce(complex(real = NA, imaginary = NA), 0+1i)) # i.e. NA_complex_
# Re Im
# [1,] 0 1
showz(fcoalesce(complex(real = 0 , imaginary = NA), 0+1i)) # i.e. unchanged
# Re Im
# [1,] 0 NA
showz(fcoalesce(complex(real = NA, imaginary = 0 ), 0+1i)) # i.e. unchanged
# Re Im
# [1,] NA 0
If this is deemed problematic we should check handling elsewhere in the codebase too.
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·