`cedta()` should pass if data.table is in Imports but not the NAMESPACE

Open
#5,661 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start with R/cedta.R at the referenced logic and inspect how package Imports and NAMESPACE entries are detected. The change is done when cedta() passes for a package that lists data.table in Imports but does not include it in NAMESPACE, while retaining the existing Depends behavior.

Written by the indexing model from the issue text.

Description

cedta

This may happen if the package is written with a preference for run-time loading of data.table, i.e. :: form is always used, e.g. data.table::setDT(x).

cedta() passes if data.table is in Depends:

https://github.com/Rdatatable/data.table/blob/88039186915028ab3c93ccfd8e22c0d1c3534b1a/R/cedta.R#L47

But the same doesn't apply to Imports:

That seems inconsistent to me.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.