keyby/key ignored if numeric indices used in j
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- r
- Domain
- data-engineering
Research direction
Start by reproducing the two examples in the issue with data.table and compare the results of symbolic and numeric j expressions under key and keyby. Determine the intended ordering behavior, then add regression coverage showing that the chosen behavior is consistent for numeric indices.
Written by the indexing model from the issue text.
Description
I find the following behaviour difference quite surprising:
dt <- data.table(iris)
dt[, .(Sepal.Length, Sepal.Width), keyby=Petal.Length] # OK: keyby respected
# Petal.Length Sepal.Length Sepal.Width
# 1: 1.0 4.6 3.6
# 2: 1.1 4.3 3.0
# 3: 1.2 5.8 4.0
# 4: 1.2 5.0 3.2
# 5: 1.3 4.7 3.2
# ---
# 146: 6.4 7.9 3.8
# 147: 6.6 7.6 3.0
# 148: 6.7 7.7 3.8
# 149: 6.7 7.7 2.8
# 150: 6.9 7.7 2.6
dt[, 1:2, keyby=Petal.Length] ## keyby ignored
# Sepal.Length Sepal.Width
# 1: 5.1 3.5
# 2: 4.9 3.0
# 3: 4.7 3.2
# 4: 4.6 3.1
# 5: 5.0 3.6
# ---
# 146: 6.7 3.0
# 147: 6.3 2.5
# 148: 6.5 3.0
# 149: 6.2 3.4
# 150: 5.9 3.0
Same happens when using key instead of keyby.
# Output of sessionInfo()
R version 4.0.4 (2021-02-15)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 21.10
Matrix products: default
BLAS: /usr/lib/x86_64-linux-gnu/openblas-pthread/libblas.so.3
LAPACK: /usr/lib/x86_64-linux-gnu/openblas-pthread/libopenblasp-r0.3.13.so
locale:
[1] LC_CTYPE=en_GB.UTF-8 LC_NUMERIC=C
[3] LC_TIME=en_GB.UTF-8 LC_COLLATE=en_GB.UTF-8
[5] LC_MONETARY=en_GB.UTF-8 LC_MESSAGES=en_GB.UTF-8
[7] LC_PAPER=en_GB.UTF-8 LC_NAME=C
[9] LC_ADDRESS=C LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C
attached base packages:
[1] stats graphics grDevices utils datasets methods base
other attached packages:
[1] data.table_1.14.2
loaded via a namespace (and not attached):
[1] compiler_4.0.4
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·