smart default for "by" argument in groupingsets()

Open
#5,322 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by reading the groupingsets() entry point and comparing its by argument with rollup() and cube(), which the issue mentions. Evaluate whether inferring by from unique(unlist(sets)) matches the existing behavior and document or test the intended default; no specific file or test is named.

Written by the indexing model from the issue text.

Description

enhancement groupingsets help-wanted

I don't understand the use of the by argument in groupingsets(). It could be infered easily with unique(unlist(sets)). It seems to me an unnecessary source of errors. Do I overlook something ? Is it for consistence with rollup and cube functions ?

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.