how to avoid check NOTE for ..variables in j?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start with the usage in R/fmelt.R and the warning logic in R/data.table.R, then read related issues #2988 and #2826. Determine the supported way for package code to use ..is.other without an R CMD check NOTE or a data.table warning, and document or validate that guidance.
Written by the indexing model from the issue text.
Description
this is related to https://github.com/Rdatatable/data.table/issues/2988
I put a line of code in R/fmelt.R
other.values = lapply(group.dt[, ..is.other], unique)
and when I checked data.table I got
* checking R code for possible problems ... NOTE
measure: no visible binding for global variable ‘..is.other’
Undefined global functions or variables:
..is.other
so I tried the usual trick,
..is.other <- NULL
But that gave me this warning from R/data.table.R,
warning("Both '",name,"' and '..", name, "' exist in calling scope. Please remove the '..", name,"' variable in calling scope for clarity.")
Eventually I removed the two dots altogether and instead used,
other.values = lapply(group.dt[, is.other, with=FALSE], unique)
which works fine (no NOTE nor warning), but from the docs and https://github.com/Rdatatable/data.table/issues/2826 it seems that with=FALSE will be deprecated in the future. If that is the case then how should R package developers who use ..something avoid that NOTE?
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·