Subsetting with Date produces error
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start at the [.data.table entry point shown in the backtrace and reproduce the supplied Date-key example. Compare it with test[.(as.Date("2020-01-02"))]; done means direct Date subsetting no longer raises the shown error and returns the matching keyed row.
Written by the indexing model from the issue text.
Description
It is known that using a numeric vector in i will be treated as subsetting by index. However, if the supplied numeric vector has some classes (e.g. Date), then it might make more sense not to subset by index but join (just like a character vector).
Consider the following example:
library(data.table)
test <- data.table(
date = seq.Date(as.Date("2020-01-01"), as.Date("2020-07-01"), by = "day"),
key = "date"
)
test[, x := rnorm(.N)]
test[as.Date("2020-01-02")]
The following error is produced:
> test[as.Date("2020-01-02")]
Error in `[.data.table`(test, as.Date("2020-01-02")) :
i has evaluated to type double. Expecting logical, integer or double.
Backtrace:
1: stop("i has evaluated to type ", typeof(i), ". Expecting logical, integer or double.")
2: `[.data.table`(test, as.Date("2020-01-02"))
3: test[as.Date("2020-01-02")]
User might expect it to behave like
> test[.(as.Date("2020-01-02"))]
Key: <date>
date x
<Date> <num>
1: 2020-01-02 -0.2380267
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·