setDT could be much simpler

Open
#4,476 2 comments 1 reaction 1 assignee View on GitHub

@jangorecki is already working on this.

Since May 22, 2020.

  • #4477 by @jangorecki — open

Assessment

This issue has not been assessed yet.

Description

benchmark

setDT function already grown pretty fat. AFAIK it was meant to be a low overhead function. Making it low overhead now would be challanging, or even impossible, without removing some of its features. Therefore it seems reasonable to introduce new argument, lets call it asis, that will make as few as possible, which is to set:

  • class
  • rownames
  • overalloc

Such a change would be helpful in case if someone wants to benchmark DT operations but for some reason would like to include time of as.data.table / as.data.frame (time of an extra deep copy). setDT already removes extra deep copy, but they have other stuff, that is unnecessary in a case of just changing class.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.