Split time-zone specific tests into their own script

Open
#4,474 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
r
Domain
testing

Research direction

Start with the main tests.Rraw script and identify the unit tests covering system and custom time zones. Keep the main script running with TZ=UTC for its duration, and move those time-zone-specific tests into a separate script. Done means the main tests avoid issues like #4472 while the system and custom time-zone tests remain covered separately.

Written by the indexing model from the issue text.

Description

tests

We should just set TZ=UTC for the duration of the main tests.Rraw, to help avoid issues like #4472.

Unit tests for system/custom time zones would then be kept in a separate script.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.