roll does not work with nanotime (integer64)
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by reproducing the reported data.table joins using roll with nanotime, bit64/integer64, and POSIXct values. Compare the observed results with the expected rolling matches and verify the behavior for numeric, integer64, and time-based inputs; the issue names no source file or test to begin from.
Written by the indexing model from the issue text.
Description
Hello, I found the following bug where using roll and nanotime
library(data.table)
library(nanotime)
library(bit64)
X = data.table(t = c(0, 1))
Y = data.table(t = c(2, 9))
# expected nbehaviour
X[Y, on = .(t), .(x.t, i.t)]
x.t i.t
1: NA 2
2: NA 9
# roll expected behaviour
X[Y, on = .(t), .(x.t, i.t), roll = 1]
x.t i.t
1: 1 2
2: NA 9
options(nanotimeFormat = "%Y-%m-%dT%H:%M:%E9S")
X = data.table(t = nanotime(c("2020-01-02T16:34:58.393243640", "2020-01-02T16:34:58.393243641")))
Y = data.table(t = nanotime(c("2020-01-02T16:34:58.393243642", "2020-01-02T16:34:58.393243649")))
# usual nonsense for NA but correct
X[Y, on = .(t), .(x.t, i.t)]
x.t i.t
1: 2262-02-18T20:47:17.227407266 2020-01-02T16:34:58.393243642
2: 2262-02-18T20:47:17.227407266 2020-01-02T16:34:58.393243649
# I think incorrect
> X[Y, on = .(t), .(x.t, i.t), roll = 1]
x.t i.t
1: 2020-01-02T16:34:58.393243641 2020-01-02T16:34:58.393243642
2: 2020-01-02T16:34:58.393243641 2020-01-02T16:34:58.393243649
# I think incorrect
> X[Y, on = .(t), .(x.t, i.t), roll = as.integer64(1)]
x.t i.t
1: 2020-01-02T16:34:58.393243641 2020-01-02T16:34:58.393243642
2: 2020-01-02T16:34:58.393243641 2020-01-02T16:34:58.393243649
# Same with POSIXct
X = data.table(t = as.POSIXct(c("2020-01-02 16:34:58.390", "2020-01-02 16:34:58.391")))
Y = data.table(t = as.POSIXct(c("2020-01-02 16:34:58.392", "2020-01-02 16:34:58.399")))
X[Y, on = .(t), .(x.t, i.t), roll = 0.001]
x.t i.t
1: 2020-01-02 16:34:58.391 2020-01-02 16:34:58.391
2: <NA> 2020-01-02 16:34:58.398
Note:
linked to https://stackoverflow.com/questions/58916594/why-does-min200-300-returns-300-for-integer64-class ?
Edit 2020-06-25
probably unlinked
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·