forder should not accept list, but forderv should
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 28/100
Research direction
Start by reading the existing forder and forderv entry points, then review the linked discussions and issues #4214, #4456, and #3447 plus PR #3817. Define the intended behavior for data.table/list input, ordering arguments, NULL, na.last=NA, messaging, and export status before implementing and testing the complete set of decisions.
Written by the indexing model from the issue text.
Description
Recent issue reported by @MichaelChirico https://github.com/Rdatatable/data.table/issues/4214 reminded me some old discussion with @mattdowle that happened in https://github.com/Rdatatable/data.table/pull/3817.
To summarize it.
fordervshould expect data.table/list inputfordershould be a replacement fororder- whenever user uses
forder(DT)there should be a (verbose?) message pointing to useforderv; edit:base::ordertakes data.frame but returns nonsense - support for a 1+ length
decreasing,methodargument #4456 - raise error for NULL input
na.last=NAshould remove0from output
- whenever user uses
also we could export forder at the same time https://github.com/Rdatatable/data.table/issues/3447
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·