Add a na.rm argument to first()/last()

Open
#4,239 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by reading the existing first(), last(), gfirst(), and glast() entry points and how grouped vectors are handled. Clarify the intended na.rm behavior for atomic and non-atomic inputs, then define completion as consistent first/last non-missing results within each group without changing data.frame semantics.

Written by the indexing model from the issue text.

Description

feature request

Personally, I'd find it useful if gfirst()/glast() would accept a na.rm argument. This would then return the first/last non missing element of a vector (within each group).

For consistency I guess also first()/last() should then accept a na.rm argument. Although I'm not sure what this would mean if a non-atomic object (i.e. a data.frame) was passed. Maybe the flag should only be honored if is.atomic(x) && nargs() == 1L?

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.