fcase doesn't recognize S4 object : lubridate example

Open

#4,131 opened on Dec 19, 2019 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: r
Domain: data

Research direction

Start by reproducing the supplied fcase example with lubridate period functions and compare its result with case_when. Trace the fcase entry point and existing tests for conditional expressions, then add coverage showing that days, months, weeks, and years retain their distinct S4 period values.

Written by the indexing model from the issue text.

Description

feature request non-atomic column

Thank you all for the hard work in creating fcase. I have tried it out on a project that I'm currently working on and encountered problems when it was used together with lubridate period creation functions. It seems to recognize lubridate::weeks, lubridate::months, lubridate::years as lubridate::days.

reprex:


# Loading packages --------------------------------------------------------

library(data.table)
library(lubridate)
#> 
#> Attaching package: 'lubridate'
#> The following objects are masked from 'package:data.table':
#> 
#>     hour, isoweek, mday, minute, month, quarter, second, wday, week,
#>     yday, year
#> The following object is masked from 'package:base':
#> 
#>     date
library(lest)

# Creating test data ------------------------------------------------------

dt <- data.table(period_unit = c("days", "months", "weeks", "years"),
                 period_length = rep(1, times = 4))

# fcase output ------------------------------------------------------------

dt[, period := fcase(period_unit == "days", days(period_length),
                     period_unit == "months", months(period_length),
                     period_unit == "weeks", weeks(period_length),
                     period_unit == "years", years(period_length))][]
#>    period_unit period_length      period
#> 1:        days             1 1d 0H 0M 0S
#> 2:      months             1 1d 0H 0M 0S
#> 3:       weeks             1 1d 0H 0M 0S
#> 4:       years             1 1d 0H 0M 0S

# case_when output --------------------------------------------------------

dt[, period := case_when(period_unit == "days" ~ days(period_length),
                         period_unit == "months" ~ months(period_length),
                         period_unit == "weeks" ~ weeks(period_length),
                         period_unit == "years" ~ years(period_length))][]
#>    period_unit period_length            period
#> 1:        days             1       1d 0H 0M 0S
#> 2:      months             1    1m 0d 0H 0M 0S
#> 3:       weeks             1       7d 0H 0M 0S
#> 4:       years             1 1y 0m 0d 0H 0M 0S

^{Created on 2019-12-19 by the reprex package (v0.3.0)}

Session info

devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.6.2 (2019-12-12)
#>  os       Linux Mint 18.3             
#>  system   x86_64, linux-gnu           
#>  ui       X11                         
#>  language en_SG:en                    
#>  collate  en_SG.UTF-8                 
#>  ctype    en_SG.UTF-8                 
#>  tz       Asia/Singapore              
#>  date     2019-12-19                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version date       lib source        
#>  assertthat    0.2.1   2019-03-21 [1] CRAN (R 3.6.1)
#>  backports     1.1.5   2019-10-02 [1] CRAN (R 3.6.1)
#>  callr         3.4.0   2019-12-09 [1] CRAN (R 3.6.1)
#>  cli           2.0.0   2019-12-09 [1] CRAN (R 3.6.1)
#>  crayon        1.3.4   2017-09-16 [1] CRAN (R 3.6.1)
#>  data.table  * 1.12.9  2019-12-19 [1] local         
#>  desc          1.2.0   2018-05-01 [1] CRAN (R 3.6.1)
#>  devtools      2.2.1   2019-09-24 [1] CRAN (R 3.6.1)
#>  digest        0.6.23  2019-11-23 [1] CRAN (R 3.6.1)
#>  ellipsis      0.3.0   2019-09-20 [1] CRAN (R 3.6.1)
#>  evaluate      0.14    2019-05-28 [1] CRAN (R 3.6.1)
#>  fansi         0.4.0   2018-10-05 [1] CRAN (R 3.6.1)
#>  fs            1.3.1   2019-05-06 [1] CRAN (R 3.6.1)
#>  glue          1.3.1   2019-03-12 [1] CRAN (R 3.6.1)
#>  highr         0.8     2019-03-20 [1] CRAN (R 3.6.1)
#>  htmltools     0.4.0   2019-10-04 [1] CRAN (R 3.6.1)
#>  knitr         1.26    2019-11-12 [1] CRAN (R 3.6.1)
#>  lest        * 1.1.0   2019-11-29 [1] CRAN (R 3.6.1)
#>  lubridate   * 1.7.4   2018-04-11 [1] CRAN (R 3.6.1)
#>  magrittr      1.5     2014-11-22 [1] CRAN (R 3.6.1)
#>  memoise       1.1.0   2017-04-21 [1] CRAN (R 3.6.1)
#>  pkgbuild      1.0.6   2019-10-09 [1] CRAN (R 3.6.1)
#>  pkgload       1.0.2   2018-10-29 [1] CRAN (R 3.6.1)
#>  prettyunits   1.0.2   2015-07-13 [1] CRAN (R 3.6.1)
#>  processx      3.4.1   2019-07-18 [1] CRAN (R 3.6.1)
#>  ps            1.3.0   2018-12-21 [1] CRAN (R 3.6.1)
#>  R6            2.4.1   2019-11-12 [1] CRAN (R 3.6.1)
#>  Rcpp          1.0.3   2019-11-08 [3] CRAN (R 3.6.1)
#>  remotes       2.1.0   2019-06-24 [1] CRAN (R 3.6.1)
#>  rlang         0.4.2   2019-11-23 [1] CRAN (R 3.6.1)
#>  rmarkdown     2.0     2019-12-12 [1] CRAN (R 3.6.1)
#>  rprojroot     1.3-2   2018-01-03 [1] CRAN (R 3.6.1)
#>  sessioninfo   1.1.1   2018-11-05 [1] CRAN (R 3.6.1)
#>  stringi       1.4.3   2019-03-12 [1] CRAN (R 3.6.1)
#>  stringr       1.4.0   2019-02-10 [1] CRAN (R 3.6.1)
#>  testthat      2.3.1   2019-12-01 [1] CRAN (R 3.6.1)
#>  usethis       1.5.1   2019-07-04 [1] CRAN (R 3.6.1)
#>  withr         2.1.2   2018-03-15 [1] CRAN (R 3.6.1)
#>  xfun          0.11    2019-11-12 [1] CRAN (R 3.6.1)
#>  yaml          2.2.0   2018-07-25 [1] CRAN (R 3.6.1)
#> 
#> [1] /home/edt/R/3.6/library
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library

Dominant language: R
Stars: 3.9k
Forks: 1.1k
Avg merge: 14h 4m
Merged PRs (30d): 4

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Support zstd-compressed package archives: CRAN's current macOS binaries fail with "unknown archive type" Open

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

r-lib/pkgdepends#485 · 3 comments · Opened Sep 20, 2026
entrez_fetch(parsed = TRUE) checks rettype "gpc" but parse_response() handles "gbc" Open

Difficulty 1/5 Under an hour Newbie friendliness 92/100

ropensci/rentrez#228 · Opened Sep 20, 2026
Nobody is told to clone the repository, and data/ means two different directories Open

beginners blocker

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

naturalis/DABDGE#17 · 1 comment · Opened Sep 19, 2026
enviPathR Open

Build Error Build OK Build Warning policies-accepted pre-review precheck-passed

Difficulty 1/5 Under an hour Newbie friendliness 84/100

Bioconductor/BiocContributions#207 · 6 comments · Opened Sep 19, 2026
Consider adding stacked and dodged bar plots Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

datacarpentry/semester-biology#1255 · Opened Sep 19, 2026

More R issues