shift give.names could apply auto-name logic to list() input

Open
#3,905 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by reproducing the shown data.table call to shift() with the list input and give.names = TRUE, then locate the shift() naming logic. Compare the result with the usual auto-naming for latitude and longitude, and add regression coverage showing the expected names.

Written by the indexing model from the issue text.

Description

feature request
set.seed(38493)
DT = data.table(latitude = runif(10, -90, 90), longitude = runif(10, -180, 180))
DT[ , shift(.(latitude, longitude), c(-1L, 1L), give.names = TRUE)]
    V1_lead_1   V1_lag_1  V2_lead_1   V2_lag_1
 1: -38.96353         NA -147.14499         NA
 2:  29.04300   2.298902  -11.81201   44.61912
 3:  85.19639 -38.963529  178.86941 -147.14499
 4: -18.45281  29.042995 -159.37338  -11.81201
 5: -24.63941  85.196393  -74.79962  178.86941
 6:  39.93444 -18.452807  -63.89377 -159.37338
 7:  89.09799 -24.639414   10.13899  -74.79962
 8: -39.62935  39.934439  111.02200  -63.89377
 9:  45.81521  89.097989   69.86217   10.13899
10:        NA -39.629354         NA  111.02200

I kind of expected give.names to apply the "usual" (in data.table context at least) auto-names to the .(latitude, longitude) input.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.