add timing test for many .SD cols

Open
#3,797 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r

Research direction

Review issue #3777 and the linked pull-request comment first, then inspect the repository's existing test and CI layout to find the timing-test location. Done means adding a CI timing regression test for many .SD columns, keeping the CRAN correctness suite quick, and documenting a reproducible example for r-devel if the root cause is followed up.

Written by the indexing model from the issue text.

Description

benchmark tests
  • Follow up to #3777. Add a test in CI somewhere to ensure it doesn't come back. I almost added it to the main test suite but didn't since we need a timing test suite anyway, and the main test suite running on CRAN should be correctness only and quick.

  • also follow up on the root cause and make a reproducible example for r-devel. See "Next step would be ..." at the bottom of this comment : https://github.com/Rdatatable/data.table/pull/3777#issuecomment-525965669

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.