nafill / setnafill could use a 'rollends' like option

Open
#3,700 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by inspecting the nafill and setnafill entry points and their existing locf behavior, then compare the requested fillends semantics with rollends in rolling joins. Use the examples in the issue to define expected leading and trailing values, and consider coverage for both functions before checking the relevant test suite.

Written by the indexing model from the issue text.

Description

enhancement 
require(data.table)
x <- list(c(NA, 1:4), c(5:8, NA))
nafill(x, "locf")
# [[1]]
# [1] NA  1  2  3  4

# [[2]]
# [1] 5 6 7 8 8

Here, I think it'd be nice to have a 'fillends=TRUE' option that'd return c(1,1,2,3,4) for first entry. similar to rollends for rolling joins.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.