Add tests for `nomatch=NA` in non-equi-join suite
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start in the non-equi-join test suite around tests 1640, where the commented nqjoin_test cases are listed. Run the existing suite and evaluate the nomatch=NA cases for x, i, and both inputs; done when the TODO is covered by active tests without losing the expected results.
Written by the indexing model from the issue text.
Description
Add tests for
nomatch=NAin non-equi-join suite (tests 1640-ish)... tested, but takes quite some time... so commented for now
@jangorecki this set of tests could be added to the GitLab suite?
Is the TODO covered by the commented tests?
# TODO: add tests for nomatch=NA..
# tested, but takes quite some time.. so commenting for now
# nqjoin_test(x, y, 3L,1643.0)
# nqjoin_test(dt1,dt2,3L,1652.0)
# nqjoin_test( x,dt2,1L,1644.0) # without NA only in x
# nqjoin_test( x,dt2,2L,1645.0)
# nqjoin_test( x,dt2,3L,1646.0)
# nqjoin_test(dt1, y,1L,1647.0) # without NA only in i
# nqjoin_test(dt1, y,2L,1648.0)
# nqjoin_test(dt1, y,3L,1649.0)
Originally posted by @MichaelChirico in https://github.com/Rdatatable/data.table/issues/2572#issuecomment-464418663
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·