"Can't assign to the same column twice in the same query" message unhelpful, and inconsistent
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start at src/assign.c around line 377 and reproduce both assignments shown in the issue, including the by case. Read the R C API documentation and the referenced Duplicated implementation to understand the available duplicate information. Done means the duplicate-assignment error is more useful and the behavior is consistent across the demonstrated query forms.
Written by the indexing model from the issue text.
Description
DT = data.table(a = 1:5)
DT[ , c('b', 'b') := 10]
# Error in `[.data.table`(DT, , `:=`(c("b", "b"), 10)) :
# Can't assign to the same column twice in the same query (duplicates detected).
In more dynamic situations, this error is rather unhelpful.
Error happens here at the C level:
if (any_duplicated(cols,FALSE)) error("Can't assign to the same column twice in the same query (duplicates detected).");
any_duplicated is part of the R C API, the second argument is from_last.
Probably OK to jump to using something with Duplicated within the if (any_duplicated(cols, FALSE)) branch.
What's more, this error doesn't occur if the assignment takes place with by:
DT[ , c('b', 'b') := 10, by = a]
# a b
# 1: 1 10
# 2: 2 10
# 3: 3 10
# 4: 4 10
# 5: 5 10
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·