setDT should be more careful on altering its input

Open
#2,683 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start with the setDT entry point and run the R reproduction shown in the issue, then compare the related issues #4240, #2487, #1916, #1244, and #683. Done means setDT(list(c = x))[] no longer removes the names attribute from the original vector x.

Written by the indexing model from the issue text.

Description

bug High

setDT remove names attribute from input vector, that should not happen.

x = c(a = 4, b = 5)
setDT(list(c = x))[]
names(x) 

Related
#4240
https://github.com/Rdatatable/data.table/issues/2487
https://github.com/Rdatatable/data.table/issues/1916
https://github.com/Rdatatable/data.table/issues/1244
https://github.com/Rdatatable/data.table/issues/683

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.